Skip to content

[occm] Fix cloud-node-controller ClusterRoleBinding subject - #3092

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
fvrk4n:fix/occm-node-controller-rbac-binding
Jul 26, 2026
Merged

[occm] Fix cloud-node-controller ClusterRoleBinding subject#3092
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
fvrk4n:fix/occm-node-controller-rbac-binding

Conversation

@fvrk4n

@fvrk4n fvrk4n commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • The system:cloud-node-controller ClusterRoleBinding in raw manifests was bound to a non-existent cloud-node-controller ServiceAccount
  • The DaemonSet uses serviceAccountName: cloud-controller-manager, and no cloud-node-controller SA is defined anywhere in the repo
  • Fixed the binding subject to cloud-controller-manager to match the actual deployment model
  • This aligns the raw manifests with the Helm chart, which already binds both roles to cloud-controller-manager

Test plan

  • Deployed raw manifests to a live cluster and verified all 3 OCCM pods are Running/Ready.
  • Verified both ClusterRoleBindings point to cloud-controller-manager SA.
  • Confirmed SA has correct RBAC permissions via kubectl auth can-i.
Fix cloud-node-controller ClusterRoleBinding to reference the correct cloud-controller-manager ServiceAccount.

@fvrk4n
[occm] Fix cloud-node-controller ClusterRoleBinding subject
402cb62 
The system:cloud-node-controller ClusterRoleBinding was bound to a
non-existent cloud-node-controller ServiceAccount. The DaemonSet uses
cloud-controller-manager, so fix the binding subject to match.
@k8s-ci-robot

k8s-ci-robot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2026
@k8s-ci-robot

k8s-ci-robot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Hi @fakman0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

k8s-ci-robot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot requested review from dulek and kayrus April 2, 2026 15:37
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2026
@fvrk4n
fvrk4n marked this pull request as ready for review April 2, 2026 15:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from stephenfin April 2, 2026 15:39
@k8s-triage-robot

k8s-triage-robot commented Jul 1, 2026

Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@kubernetes-prow kubernetes-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2026
@gouthampacha

gouthampacha commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test
/release-note-none
/remove-lifecycle stale

@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2026
@gouthampacha

gouthampacha commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

/release-note

@kubernetes-prow

kubernetes-prow Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

@gouthampacha: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```
Details

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gouthampacha

gouthampacha commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

hey @fvrk4n : thanks for this fix, and apologies for the long delay in getting this tested.. it appears you could fix the release note in the PR description and it'd get picked up. ..
other than that this fix lgtm..

@gouthampacha

gouthampacha commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

/release-note
sorry, my earlier /release-note-none was incorrect.

@kubernetes-prow

kubernetes-prow Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

@gouthampacha: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```
Details

In response to this:

/release-note
sorry, my earlier /release-note-none was incorrect.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gouthampacha

gouthampacha commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

sigh, let me fight the bot

/remove-label release-note-none

@kubernetes-prow

kubernetes-prow Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

@gouthampacha: The label(s) /remove-label release-note-none cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

sigh, let me fight the bot

/remove-label release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gouthampacha

gouthampacha commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

@fvrk4n could you do a small edit on the PR description (add/remove a space) to trigger the bot to re-parse the release note block? I accidentally set the wrong label and can't seem to undo it.

@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 25, 2026
@fvrk4n

fvrk4n commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

@fvrk4n could you do a small edit on the PR description (add/remove a space) to trigger the bot to re-parse the release note block? I accidentally set the wrong label and can't seem to undo it.

Sure.

@gouthampacha

gouthampacha commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

/lgtm

thanks @fvrk4n

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2026
@kayrus

kayrus commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

/approve

@kubernetes-prow

kubernetes-prow Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit e5fdb07 into kubernetes:master Jul 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dulek dulek Awaiting requested review from dulek
@kayrus kayrus Awaiting requested review from kayrus
@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

@gouthampacha gouthampacha

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fvrk4n @k8s-ci-robot @k8s-triage-robot @gouthampacha @kayrus